dkirillov/gh-26: Renderer and Executor determined by the shore config #73
Conversation
loading of shore config happens in PersistentPreRun
dkirillov
changed the title
dkirillov
added
enhancement
Made use of ShoreConfigOpts
update the unit test
pkg/command/dependencies.go
Outdated
| // Select the Renderer | ||
| switch strings.ToLower(shoreConfig.Renderer[`type`].(string)) { | ||
| case JSONNET: | ||
| d.Logger.Debug("Using the Jsonnet Renderer") | ||
| chosenRenderer = jsonnet.NewRenderer(d.Project.FS, d.Project.Log) | ||
| default: | ||
| return fmt.Errorf("the following Renderer is undefined: %s", shoreConfig.Renderer[`type`].(string)) | ||
| } | ||
| d.Renderer = chosenRenderer |
There was a problem hiding this comment.
Please move this sections to it's own function.
There was a problem hiding this comment.
Done.
Looks a bit cleaner.
pkg/command/dependencies.go
Outdated
| // Select the Backend | ||
| switch strings.ToLower(shoreConfig.Executor[`type`].(string)) { | ||
| case SPINNAKER: | ||
| d.Logger.Debug("Using the Spinnaker Backend") | ||
| chosenBackend = spinnaker.NewClient(d.Project.Log) | ||
| default: | ||
| return fmt.Errorf("the following Executor is undefined: %s", shoreConfig.Executor[`type`].(string)) | ||
| } | ||
| d.Backend = chosenBackend |
There was a problem hiding this comment.
Please move this section to it's own function (I.E. loadBackend).
| ShoreConfig config.ShoreConfig | ||
| ShoreConfigOpts config.ShoreConfigOpts |
There was a problem hiding this comment.
Aside from tests, where are these fields used?
There was a problem hiding this comment.
Currently, they're not being used anywhere.
The intent is to have them there early so when render/save/execute/test-remote commands start making use of the shore config the information will already be there.
For instance, when the render command is ran it will have the shore config loaded in the dependencies as well as the chosen profile - and so it will be able to use the correct config based on the profile (all of which it will have access to).
Overview
Github Issue: #26
Summary (required always)
This PR makes use of the new shore config, by loading it and using it to determine the type of renderer and executor to use.
(Functionality of
LoadShoreConfigintroduced in 7c38b57)Done on a project that has a shore config, it will load it and use the types defined for the renderer and executor.
When a project does not have a shore config, it will drop a default one.
Notes
Unit tests pass
To test, installed a local version from branch's source
shore helprequires no configuration and should always work, so it was tested.shore help- outside a shore project - should workshore help- inside a shore project - should workshore renderandshore savewere picked and tested becauserenderrelies on the renderer type being set, andsaverelies on the renderer type and the executor type being set.shore render- outside a shore project - shouldn't workshore render- inside a shore project - should work - also drops a new shore configThis was the first time that this was ran in this shore project, so a shore config was created.
shore save- outside a shore project - shouldn't workshore save- inside a shore project - should work - also loads an existing shore configThis was ran after
shore render, and so the shore config was already there and was loaded and used.shore render- inside a shore project, bad renderer type - shouldn't workshore save- inside a shore project, bad executor type - shouldn't workChecklist
<username>/<gh-issue-#number>:<short-description>